Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display invited company name in OSP consent form #1083

Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: Display invited company name in OSP consent form #1083

merged 5 commits into from
Sep 6, 2024

Conversation

JordanGerada3
Copy link
Contributor

@JordanGerada3 JordanGerada3 commented Sep 6, 2024 •
edited
Loading

Description

Company name in OSP form was hardcoded with "BMW"

Why

Company name in OSP company details form should reflect the actual company

Issue

#1080

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

ybidois
ybidois approved these changes Sep 6, 2024
View reviewed changes
Copy link

@ybidois ybidois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JordanGerada3 JordanGerada3 changed the title fix: Remove hardcoded company name to actual company name fix: Display invited company name in OSP consent form Sep 6, 2024
typecastcloud
typecastcloud reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry is missing

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit 4ac2435 into eclipse-tractusx:main Sep 6, 2024
8 checks passed
@evegufy evegufy added this to the Release 24.12 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@ybidois ybidois ybidois approved these changes

@shubhamv-ss shubhamv-ss Awaiting requested review from shubhamv-ss

@ss-nikunj ss-nikunj Awaiting requested review from ss-nikunj

@isaadansari isaadansari Awaiting requested review from isaadansari

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanGerada3 @oyo @ybidois @typecastcloud @evegufy