Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename 'appsubscription' to 'appSubscription' in notification.json #1054

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Aug 29, 2024

Description

Renamed the translation key from appsubscription to appSubscription in the notification.json file to fix a key mismatch.

Why

The text link.appSubscription is displayed because the key appSubscription does not exist in the translation file, as the current key is incorrectly named appsubscription.

Issue

1053

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

sonarcloud bot commented Aug 29, 2024

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Aug 29, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaximilianHauer
Copy link

@oyo can be merged

@Phil91 Phil91 merged commit af14873 into eclipse-tractusx:main Aug 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants