Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change app adminBoard and adminBoardDetail route #1049

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Aug 28, 2024

Description

Renamed adminBoard to appAdminBoard and adminBoardDetail to appAdminBoardDetail to maintain consistent naming conventions across the portal.

Changes:

  • Updated the route for the Apps admin board to match the naming logic used for Services.
  • Ensured proper camel case formatting.

Why

To maintain consistency in naming conventions.

Issue

1045

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. but workflows awaiting approval

Phil91
Phil91 previously approved these changes Aug 29, 2024
@Phil91 Phil91 self-requested a review August 29, 2024 08:22
@Phil91
Copy link
Member

Phil91 commented Aug 29, 2024

@shahmargi12 could you please resolve the conflicts? I think it's because I merged another PR into the main branch.

Copy link

sonarcloud bot commented Aug 29, 2024

@shahmargi12
Copy link
Contributor Author

@shahmargi12 could you please resolve the conflicts? I think it's because I merged another PR into the main branch.

Hello @Phil91 , The conflicts have been resolved.

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Aug 30, 2024
@oyo oyo merged commit f12ff2a into eclipse-tractusx:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

5 participants