Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user management): fix disable button state when deselect all checkboxes [updated] #923

Conversation

saadanzari
Copy link
Contributor

Description

Users/Admins are able to deselect all roles assigned to them and confirm during role updates.

Users should not be able to confirm the role update after deselecting all roles assigned to them. At least one role should remain selected at all times.

Users should not be able to confirm the role update after deselecting all roles assigned to them. At least one role should remain selected at all times.

Why

Please include an explanation of why this change is necessary as well as relevant motivation and context. List any dependencies that are required for this change.

Issue

#919

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@saadanzari saadanzari closed this Jul 12, 2024
@saadanzari saadanzari reopened this Jul 12, 2024
@evegufy evegufy changed the base branch from release/v2.1.0-RC1 to release/v2.1.0-RC2 July 12, 2024 15:29
@evegufy
Copy link
Contributor

evegufy commented Jul 12, 2024

Hi @saadanzari thank you for your contribution! I needed to release the release candidate for the 2.1.0 version, could you please solve conflict in the with the changelog?

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

CHANGELOG.md Outdated Show resolved Hide resolved
@saadanzari saadanzari requested a review from evegufy July 15, 2024 08:48
CHANGELOG.md Outdated Show resolved Hide resolved
@saadanzari saadanzari requested a review from evegufy July 15, 2024 08:59
@evegufy evegufy merged commit 087b451 into eclipse-tractusx:release/v2.1.0-RC2 Jul 15, 2024
7 checks passed
@saadanzari saadanzari deleted the fix/disable-deselect-roles-on-update branch July 15, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants