yarn upgrade: avoid vscode-jsonrpc@6 #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
bug
vince-fugnitto
approved these changes
Dec 15, 2020
`[email protected]` depends on `vscode-jsonrpc@6` which breaks our build. We expect to have `vscode-jsonrpc@5`. Signed-off-by: Paul <[email protected]>
paul-marechal
force-pushed
the
mp/yarn-upgrade
branch
from
ed70b19 to
dd80a0d
Compare
perrinjerome
added a commit
to perrinjerome/theia
that referenced
this pull request
Sep 2, 2022
It was breaking the build at the time of eclipse-theia#8868 but there is no such problem anymore Signed-off-by: Jérome Perrin <[email protected]>
perrinjerome
added a commit
to perrinjerome/theia
that referenced
this pull request
Sep 2, 2022
It was breaking the build at the time of eclipse-theia#8868 but there is no such problem anymore. Re-running yarn also updated ts-md5 (and other things), so the import had to be adjusted. Signed-off-by: Jérome Perrin <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #8862
[email protected]depends onvscode-jsonrpc@6which breaks our build. We expect to have
vscode-jsonrpc@5.Signed-off-by: Paul [email protected]
How to test
yarn upgradeyarn why vscode-jsonrpcshould not show a version different from[email protected]Review checklist
Reminder for reviewers