Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customization of configuration area for customer application #14319

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

rschnekenbu
Copy link
Contributor

What it does

Adds an application prop to define the location of the configuration area.
This property can be used by theia-based applications to customize their own configuration area. The logic of the THEIA_CONFIG_DIR environment variable should still works and it should override this application prop, without the need of overriding the environment variable server.

fixes #14318

Contributed on behalf of STMicroelectronics

How to test

  • Sample application can be used without modification. '.theia' should be the default configuration folder (default prop is used)
  • Setting an env variable to another folder (export THEIA_CONFIG_DIR=".theia-configDir") for example, and re-test with the sample application.
  • Unset the environment variable and setting the application property in the sample application package.json to "configurationFolder" : ".theia-example". Config dir shall be $home/.theia-example
  • Set again the env property. The environment property should override the configurationFolder value

Follow-ups

Review checklist

Reminder for reviewers

…ation

fixes eclipse-theia#14318

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu rschnekenbu merged commit fa7597a into eclipse-theia:master Oct 28, 2024
11 checks passed
@jfaltermeier jfaltermeier added this to the 1.55.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow definition of configuration folder in the application properties
3 participants