Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context for multiple notebooks #13566

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

  • Focuses and puts the first cell in edit mode when creating a new empty notebook
  • fixes context for multiple open notebooks (this seemed to be broken before)

How to test

Create a new notebook. See first cell is selected and the editor is focused.

Create a second new notebook. cell toolbar should show the correct entries

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden requested a review from msujew April 4, 2024 11:50
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jonah-iden jonah-iden merged commit 9b0e47f into master Apr 4, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/focus-first-cell-if-new-notebook branch April 4, 2024 13:28
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 4, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants