Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic notebook widgets resizing #13289

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix dynamic notebook widgets resizing #13289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cccd11
fix resizing of dynamic widgets
jonah-iden Jan 19, 2024
8efcdde
Update output-webview-internal.ts
jonah-iden Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/plugin-ext/src/main/browser/notebooks/renderers/output-webview-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,20 @@ export async function outputWebviewPreload(ctx: PreloadContext): Promise<void> {
private onRenderCompleted(): void {
// we need to check for all images are loaded. Otherwise we can't determine the correct height of the output
const images = Array.from(document.images);
console.log(images);
images?.forEach(img => img.onresize = e => console.log(e));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forgot to remove the debug logging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups yes thanks for pointing that out

if (images.length > 0) {
Promise.all(images.filter(img => !img.complete).map(img => new Promise(resolve => { img.onload = img.onerror = resolve; }))).then(() =>
theia.postMessage(<webviewCommunication.OnDidRenderOutput>{ type: 'didRenderOutput', contentHeight: document.body.clientHeight }));
Promise.all(images.filter(img => !img.complete).map(img => new Promise(resolve => { img.onload = img.onerror = resolve; }))).then(() => {
theia.postMessage(<webviewCommunication.OnDidRenderOutput>{ type: 'didRenderOutput', contentHeight: document.body.clientHeight });
new ResizeObserver(() =>
theia.postMessage(<webviewCommunication.OnDidRenderOutput>{ type: 'didRenderOutput', contentHeight: document.body.clientHeight }))
.observe(document.body);
});
} else {
theia.postMessage(<webviewCommunication.OnDidRenderOutput>{ type: 'didRenderOutput', contentHeight: document.body.clientHeight });
new ResizeObserver(() =>
theia.postMessage(<webviewCommunication.OnDidRenderOutput>{ type: 'didRenderOutput', contentHeight: document.body.clientHeight }))
.observe(document.body);
}

}
Expand Down
Loading