fix(preference-tree-widget): sync. Theia and VSCode behavior about extensions' node naming

[VGRSTM]

What it does

Fix #12928

Contributed by STMicroelectronics
Signed-off-by: Vincent GRENET [email protected]

How to test

1. Hack package.json of your preferred VSCode extension
2. Install it within Theia
3. Just check configuration.title is now considered asking for Settings widget

Follow-ups

Review checklist

• [X ] As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Alright, behavior looks mostly good, I just have a few remarks on the code and one on the behavior: The TypeScript extension provides preferences starting with typescript.* and javascript.*. Since both use the same title, but with a different group ID, these get listed twice as separate groups in the preferences:

VSCode shows them as expected only as a single group.

[msujew]

Suggestion: Since title is an optional property, using 'title' in node can lead to false negative results.

Suggested change

	export const is = (node: BaseTreeNode): node is CompositeTreeNode => 'depth' in node && 'title' in node;
	export const is = (node: BaseTreeNode): node is CompositeTreeNode => 'depth' in node;

[VGRSTM]

Good to me. I'll integrate this suggestion.

[msujew]

Suggestion: We don't need to make it so complicated by first getting all the keys.

Suggested change

	const keys = Object.keys(config.properties);
	keys.forEach(key => { config.properties[key].title = config.title; });
	Object.values(config.properties).forEach(property => property.title = config.title);

[VGRSTM]

Good to me. I'll integrate this suggestion.

[VGRSTM]

Alright, behavior looks mostly good, I just have a few remarks on the code and one on the behavior: The TypeScript extension provides preferences starting with typescript.* and javascript.*. Since both use the same title, but with a different group ID, these get listed twice as separate groups in the preferences:

Ok got it. Good point. I'll work a bit more on tree generator to get proper "merge" of such nodes sticking VSCode rendering.
Thanks for this first review !

[JonasHelming]

@VGRSTM Do you plan to update this PR?

[VGRSTM]

@VGRSTM Do you plan to update this PR?

Have got no time to allocate to up to now

[msujew]

Superseded by #13819. Closing this PR.