fix(quick-open-task): fix build task filtering #12918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed by STMicroelectronics Signed-off-by: Vincent GRENET <[email protected]>
VGRSTM
force-pushed
the
pr/vgrstm-bugfix-12917
branch
from
52505f5 to
804304d
Compare
|
@vince-fugnitto sounds you have triggered ACI checks. One is failing for a reason I'm not mastering (timeout ?). I've not found way to rerun ... feel free I rely on you. Thanks |
|
On it, just need to verify how to reproduce the original bug: #12917 (comment) |
|
I pushed #13075 as a fix for the underlying issue. So I don't think this PR is still needed. Please let me know, if this isn't correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix #12917
Contributed by STMicroelectronics
Signed-off-by: Vincent GRENET [email protected]
How to test
Create a build type task and check it is promoted relying on
Task: Run Build TaskcommandReview checklist
Reminder for reviewers