playwright: cleanup build process #12248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@planger do you have any objections to the following approach? |
|
Thanks for pinging me @vince-fugnitto! I don't have any objections. Good idea to minify if Playwright isn't needed. |
The commit updates the `@theia/playwright` package to not install it's dependencies on startup since we often do not run the tests manually but instead handles the package similarly to our examples where they can built on demand. The change should improve the build process without irrelevant logs. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/cleanup-playwright
branch
from
33d97be to
8cf978f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request cleans up the build process which previously would automatically install playwright dependencies such as chromium when performing
yarnon the repo (due to thepreparescript). The change cleans up the build so that playwright can be built only when needed (ex: when we need to run the suite) and not unnecessarily.How to test
Review checklist
Reminder for reviewers