-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to lerna 5.5.4 #11738
Upgrade to lerna 5.5.4 #11738
Conversation
7906684
to
28b253f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- Build is successful, and both the
example-electron
andexample-browser
work - CI passes
- Confirmed that vulnerabilities previously reported by
yarn audit
have been resolved (new one from axios as expected) - Confirmed that
yarn run improved-yarn-audit
works and reports the vulnerabilities in a nice format - Confirmed that
yarn run improved-yarn-audit --ignore-dev-deps
works and does not reportdevDependencies
084e353
to
2ec7ef0
Compare
@vince-fugnitto as suggested during the dev-meeting, I added an entry to the migration guide. And since there was a conflict with |
2ec7ef0
to
1966102
Compare
Fixes #11737 before update: 7 vulnerabilities found - Packages audited: 1946 Severity: 3 Moderate | 2 High | 2 Critical after update: 2 vulnerabilities found - Packages audited: 2036 Severity: 1 Moderate | 1 High Signed-off-by: Marc Dumais <[email protected]>
"improved-yarn-audit" (license: MIT), complements plain "yarn audit", making audits easier to integrate in CI pipelines. The output is short and to-the-point, making it useful immediately. Simple usage examples: $> yarn run improved-yarn-audit $> yarn run improved-yarn-audit --ignore-dev-deps Here's the currint output for the Theia repo (with this PR in): $> yarn run improved-yarn-audit Improved Yarn Audit - v3.0.0 Minimum severity level to report: low Running yarn audit... Found 2 vulnerabilities Vulnerability Found: Severity: MODERATE Modules: jsdom URL: GHSA-f4c9-cqv8-9v98 Vulnerability Found: Severity: HIGH Modules: lerna>nx>axios URL: GHSA-cph5-m8f7-6c5x Signed-off-by: Marc Dumais <[email protected]>
1966102
to
1ad85b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What it does
Fixes #11737
This PR updates dev-dependency
lerna
, from 4.x to latest 5.x. In the process we get rid of several important security vulnerabilities, that we have carried for a long while (that affect the development environment only, not Theia-based products at runtime).We also introduce a new
dev-dependency
, improved-yarn-audit, that complementsyarn audit
nicely. Its behaviour is more configurable and its output parse-able, which makes it easier to eventually integrate to CI.Simple usage examples:
$> yarn run improved-yarn-audit
$> yarn run improved-yarn-audit --ignore-dev-deps
How to test
axios
dependency of lerna, used bynx
(they have a couple of related issues on their project, to use a lateraxios
, so it will be fixed soon I hope)note: be careful if you happen to have the production registry configured on your machine. Consider moving the corresponding
.npmrc
file temporarily to avoid pushing to real registry by mistake$> npm add -g verdaccio
$> verdaccio
# start verdaccio in another terminal$> npm config set registry http://localhost:4873/
$> yarn config set registry http://localhost:4873/
$> npm adduser --registry http://localhost:4873/
# use bogus user/credentials. e.g.: test/test/[email protected]$> git clean -ffdx && yarn && yarn build:examples && yarn test:theia
$> npx lerna publish --registry http://localhost:4873 --exact --yes --no-push && yarn -s publish:check
$> git clean -ffdx && yarn && yarn build:examples && yarn test:theia
$> npx lerna publish --registry http://localhost:4873 preminor --exact --canary --preid next --dist-tag next --no-git-reset --no-git-tag-version --no-push --yes && yarn -s publish:check
yarn.lock
as you continue working on something else:$> npm config delete registry http://localhost:4873/
$> yarn config delete registry http://localhost:4873/
Review checklist
Reminder for reviewers