Skip to content

Conversation

@kittaakos
Copy link
Contributor

What it does

From now on, the electron main sends an event to the frontend via IPC ('keyboardLayoutChanged') if the OS layout changes.

Closes #11688

How to test

I did the following (on macOS):

  • build and start the electron example in debug mode,
  • add a breakpoint to here and here and change your OS layout,
  • you will hit both breakpoints.

Review checklist

Reminder for reviewers

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@paul-marechal paul-marechal merged commit b75b614 into eclipse-theia:master Sep 21, 2022
@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Sep 29, 2022
@vince-fugnitto vince-fugnitto added this to the 1.30.0 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

electron issues related to the electron target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[electron] ElectronNativeKeymap is unused?

3 participants