Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls: add additional localizations #11368

Merged
merged 3 commits into from
Jun 30, 2022
Merged

nls: add additional localizations #11368

merged 3 commits into from
Jun 30, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

In additon to #11367, I noticed a couple of other instances where we do no localize.
The pull-request updates both the open and save dialog to localize all user facing strings, including tooltips.

How to test

  1. confirm that the strings updated in the pull-request are not actually localized when changing display language on master
  2. the strings should be properly localized when we perform Regular translation update #10885.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Jun 29, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@vince-fugnitto
Copy link
Member Author

Sorry @msujew, I noticed that the keyboard shortcuts widget was completely not localized so I added a commit for it, should I open a separate pull-request instead? I might do a pass to see if we have other areas that are no localized.

@msujew
Copy link
Member

msujew commented Jun 29, 2022

@vince-fugnitto I'm fine with having multiple non-localized areas fixed in a single PR.

@vince-fugnitto vince-fugnitto changed the title nls: add additional localizations to dialogs nls: add additional localizations Jun 29, 2022
@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Jun 29, 2022

I went ahead and updated other occurrences of missing localisations I could identify 👍

@msujew
Copy link
Member

msujew commented Jun 30, 2022

@vince-fugnitto Thanks 👍 Do you plan on merging this today? I could include it in the localization update.

@vince-fugnitto vince-fugnitto merged commit ce1ac15 into master Jun 30, 2022
@vince-fugnitto vince-fugnitto deleted the vf/localize-dialog branch June 30, 2022 11:35
@vince-fugnitto
Copy link
Member Author

@msujew thank you! please go ahead :)

@github-actions github-actions bot added this to the 1.27.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants