-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nls: add additional localizations #11368
Conversation
Signed-off-by: vince-fugnitto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 👍
Sorry @msujew, I noticed that the |
@vince-fugnitto I'm fine with having multiple non-localized areas fixed in a single PR. |
9e9d9c3
to
c2b9613
Compare
Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: vince-fugnitto <[email protected]>
c2b9613
to
5a07a43
Compare
I went ahead and updated other occurrences of missing localisations I could identify 👍 |
@vince-fugnitto Thanks 👍 Do you plan on merging this today? I could include it in the localization update. |
@msujew thank you! please go ahead :) |
What it does
In additon to #11367, I noticed a couple of other instances where we do no localize.
The pull-request updates both the
open
andsave
dialog to localize all user facing strings, including tooltips.How to test
Review checklist
Reminder for reviewers