-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(commad): close #11346, use available number to label when create … #11347
fix(commad): close #11346, use available number to label when create … #11347
Conversation
… when create untitled file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiliang114 Thank you for your first contribution!
I believe we can greatly simplify this change and cut down on the logic duplication. See below on how we could accomplish this.
…clipse-theia#11346) Signed-off-by: yiliang114 <[email protected]>
Signed-off-by: yiliang114 <[email protected]>
…fix/new-untitled-file-index
Co-authored-by: Mark Sujew <[email protected]>
Signed-off-by: yiliang114 <[email protected]>
Signed-off-by: yiliang114 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good already, however the changes to the plugin host code crash the runtime. See below for how to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, the changes look good to me 👍
What it does
close #11346
after change:
How to test
http://localhost:3000/
and open any workspace.alt + n
to callNEW_FILE
command some times, we can see tab namedUntitled-${index}
one by one. The number in label is start from1
like vscode.NEW_FILE
command again after close some older Untitled file, it will use the number which is closed just now like vscode.Review checklist
Reminder for reviewers