-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSX: Add 'Install Another Version...' Command #11303
VSX: Add 'Install Another Version...' Command #11303
Conversation
c01e35b
to
dbd5748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes and the functionality are looking quite good to me already. I have some concerns about adding further dependencies on the moment
lib though, see below.
packages/vsx-registry/src/browser/vsx-extensions-contribution.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good to me 👍
- Using the context menu command to install another extension works correctly
- The extension shows the
Reload Required
button - Uninstalling/Installing extensions works as expected
Supports the ability to install any compatible version of an user-installed extension, provided that the extension is available in the Open VSX Registry. Co-authored-by: seantan22 <[email protected]> Co-authored-by: Colin Grant <[email protected]>
ac69445
to
2cae3db
Compare
What it does
Closes #9330, on which this PR is based.
install_another_version.mp4
How to test
Installed
view of all user-installed extensions.manage
gear icon --> ClickInstall Another Version...
command. Note that the command is disabled for any extension not available in the Open VSX Registry.Reload Required
, but the plugin continues working.Reload Required
and you run the command again and select the version currently running,Reload Required
should change toUninstall
, and reloading should retain the same version.Review checklist
Reminder for reviewers
Signed-off-by: seantan22 [email protected]