Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(10602): remove duplicate margin property in breadcrumb #11247

Conversation

hemanthemmady
Copy link
Contributor

@hemanthemmady hemanthemmady commented Jun 2, 2022

What it does

Fixes: #10602

The pull-request removes a duplicate margin property in the breadcrumb CSS file that was having no effect on the application.

How to test

Confirm the styling is correct.

Review checklist

Reminder for reviewers

Signed-off-by: Hemant Hemmady [email protected]

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality ui/ux issues related to user interface / user experience labels Jun 3, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemanthemmady the changes look good to me, thank you for your first contribution to the project! 👍

@vince-fugnitto vince-fugnitto merged commit 40e6266 into eclipse-theia:master Jun 3, 2022
@hemanthemmady hemanthemmady deleted the fix/remove-duplicate-margin-breadcrumb branch June 3, 2022 04:15
@vince-fugnitto vince-fugnitto added this to the 1.27.0 milestone Jun 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS duplicate margin property without effect
2 participants