Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developing.md #11227

Closed
wants to merge 1 commit into from
Closed

Update Developing.md #11227

wants to merge 1 commit into from

Conversation

fipro78
Copy link
Contributor

@fipro78 fipro78 commented May 31, 2022

Fix indentation

Signed-off-by: Dirk Fauth [email protected]

Fix indentation
@JonasHelming
Copy link
Contributor

@fipro78 : Hi Dirk and thank you for the contribution! Could you please check whether your ECA is signed with the same E-Mail address used in the commit? Otherwise the ECA validation will fail (it currently fails)

@JonasHelming JonasHelming added the documentation issues related to documentation label May 31, 2022
@fipro78
Copy link
Contributor Author

fipro78 commented May 31, 2022

@JonasHelming Well the Signed-off-by email is my Eclipse account email address ... but as I did a simple modification in the GitHub browser UI it seems the author email is not set accordingly. Any idea how I can change this?

Otherwise it is a very simple formatting fix as the list was not correct and confused me a bit. If there is too much hassle to get things working, feel free to abandon this change and fix it directly please. :)

I think I need to get my private GitHub account configured to make it work with Eclipse GitHub projects. Not sure how but I will find out.

@msujew
Copy link
Member

msujew commented May 31, 2022

@fipro78 You can do something like this:

git commit --amend --author="John Doe <[email protected]>"

To change the name and email address of your last commit.

@fipro78
Copy link
Contributor Author

fipro78 commented May 31, 2022

@msujew Thanks, I am aware of the command line options. :)

The problem is that I am behind a corporate firewall and can not push via ssh or https to GitHub. So I would need to start my private laptop, checkout the sources, modify and push. And my hope was that with the editing on GitHub in the browser I could skip that. At the end that is the major benefit of a cloud based editor, to skip the local stuff for minimal changes.

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 1, 2022

I created a new PR #11234 with the correct email address as author. The local checkout variant would have surely worked, but I wanted to verify a working process in the web based user interface. Hope that this is ok for you.

@fipro78 fipro78 closed this Jun 1, 2022
@fipro78 fipro78 deleted the patch-1 branch June 1, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants