Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix files.eol preferences cannot display correctly #11079

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix files.eol preferences cannot display correctly #11079

merged 1 commit into from
Apr 28, 2022

Conversation

gaomin
Copy link
Contributor

@gaomin gaomin commented Apr 27, 2022

What it does

#4110
https://community.theia-ide.org/t/preference-files-eol-cannot-display-correctly/2368

How to test

click menu: Preferences => Open Settings(UI) => Files Eol => edit & show options

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaomin Thanks for your first contribution 👍

This addresses the issue at hand, but might introduce another issue. See the comment below.

@vince-fugnitto vince-fugnitto added preferences issues related to preferences labels Apr 27, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit 2ccf321 into eclipse-theia:master Apr 28, 2022
@colin-grant-work colin-grant-work added this to the 1.25.0 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants