Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach QP to body but position at top of main panel #11054

Conversation

colin-grant-work
Copy link
Contributor

What it does

On master, the Quick Pick can be occluded by the right side panel. This is a consequence of a recent change to attach the QP container to the ApplicationShell's main panel. This PR adjusts the logic for positioning the QP container to ensure that appears at the top of the main panel, but resides in the body.

How to test

  1. Open a panel in the right panel and expand the panel.
  2. Open a Quick Pick (e.g. using ctrl+p for file quick pick)
  3. Observe that the QP appears at the top of the main panel (below the menu) and is not occluded by the right pane.
  4. Enter Zen mode ('View: Toggle Maximized' with an editor visible) or reveal the toolbar ('View: Toggle Toolbar')
  5. Repeat steps 2-3.

master:
image

This PR:
image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added monaco issues related to monaco quick-open issues related to the quick-open labels Apr 21, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected 👍

  • the quick-input menu displays properly with different layouts
  • the quick-input is correctly displayed above all other content (bug that the pr resolves)
  • the quick-input works well with other content such as the toolbar (since it uses the main-panel)

@colin-grant-work colin-grant-work merged commit 552b5ee into eclipse-theia:master Apr 22, 2022
@colin-grant-work colin-grant-work deleted the bugfix/quick-pick-occlusion branch April 22, 2022 15:51
@colin-grant-work colin-grant-work added this to the 1.25.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco quick-open issues related to the quick-open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants