Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing lib folder to package.json's files #11014

Conversation

planger
Copy link
Contributor

@planger planger commented Apr 12, 2022

Change-Id: Icdf84ef17c208bf90a77abf3ef71e9b474d4ec1c

What it does

Add the lib folder to the files property of the package.json.
Otherwise the compiled sources aren't included when the package is installed as a dependency.

How to test

Once published, the compiled dependenciesin lib should be published.

Review checklist

Reminder for reviewers

Change-Id: Icdf84ef17c208bf90a77abf3ef71e9b474d4ec1c
@planger
Copy link
Contributor Author

planger commented Apr 12, 2022

I'm afraid we missed to include the lib folder (see also https://community.theia-ide.org/t/using-theia-playwright-framework/2339/4=). In our downstream projects, we for now only consumed this package by including the sources. So we didn't catch this issue.

@vince-fugnitto can you please have a look and merge this, if you are ok with this change? Once published, it should then include the compiled sources.

@vince-fugnitto vince-fugnitto added the playwright issues related to playwright tests label Apr 12, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vince-fugnitto vince-fugnitto merged commit 07dcfbd into eclipse-theia:master Apr 12, 2022
@planger planger deleted the playwright-add-missing-lib-files branch April 12, 2022 18:58
@vince-fugnitto vince-fugnitto added this to the 1.25.0 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright issues related to playwright tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants