Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add support for title property in InputBoxOptions #10920

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Mar 24, 2022

What it does

Fixes: #10030.

The pull-request adds support for the title property in InputBoxOptions which is used to give a title to quick-input menus.
The change also includes styling updates to the quick-input to give the input the same styling as the rest of the application's input fields, and also sets the title background similarly to VS Code.

title-pr.mp4

How to test

  1. include the following test extension: vscode-input-0.0.1.zip
  2. include the following theme extension: vs-theme-0.0.1.zip
  3. start the application, and execute the hello world command
  4. a quick-input should be triggered which has a title property
  5. confirm the quick-input work
  6. using different themes confirm that quick-inputs are properly styled
  7. confirm the title is blue with the test-theme

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added monaco issues related to monaco vscode issues related to VSCode compatibility ui/ux issues related to user interface / user experience labels Mar 24, 2022
The commit adds support for the `title` property in `InputBoxOptions`
which allows users to specify a title for their quick-input menus.

The change also aligns the styling of the quick-input to use the proper
input background used across the application, and for the `title`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

@msujew it turns out that the color is contributed by monaco so we do not need to register it ourselves, but instead can directly use it. As part of the steps to test the pull-request I created a theme that sets a specific color to the title and it works correctly 👍

title-pr.mp4

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looking good 👍

@vince-fugnitto vince-fugnitto merged commit 7efbe62 into master Mar 29, 2022
@vince-fugnitto vince-fugnitto deleted the vf/monaco-title branch March 29, 2022 15:58
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add InputBoxOptions#title
2 participants