-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align tabbar styling to vscode #10908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and closely mirrors the behavior of VSCode 👍. Would be nice to get others' opinions before merging, as I'm not a particularly sensitive observer of design aesthetics. @vince-fugnitto, @JonasHelming
One thing I've noticed just now is that it looks like we have two levels of tabbar prominence: the active tabs on all tabbars have the same level of prominence, and the inactive tabs are all the same. But VSCode has four: The inactive tabs on the active tabbar are different from the inactive tabs on inactive tabbars, and the active tab on the active tabbar is different from the active tab on the inactive tabbar. |
@colin-grant-work Thanks for the hint, I added support for "active/inactive" tabbars and adjusted the tabbar font color as needed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2a47f28
to
fe22518
Compare
@vince-fugnitto I've decided to replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍
I confirmed that the styling of tabs in the main-area and bottom area work well, there is no flicker and if a theme sets the tab.activeBorderTop
it is applied.
@msujew perhaps out of the scope of the pull-request but should we use the same box-shadow
trick to properly apply tabs.activeBorder
?
Border on the bottom of an active tab. Tabs are the containers for editors in the editor area. Multiple tabs can be opened in one editor group. There can be multiple editor groups.
I used vs-theme-0.0.1.zip to test:
"colors": {
"tab.activeBorderTop": "#00ff00",
"tab.activeBorder": "#ff0000"
}
vscode:
pull-request:
fe22518
to
12dd01a
Compare
@vince-fugnitto Yep, was perfectly doable using the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are a really nice improvement 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reaffirm my approval with the latest changes: All four levels of prominence are respected for tabs.
45f7a3b
to
aeb6c00
Compare
What it does
Closes #10906
How to test
Review checklist
Reminder for reviewers