Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TailDecoration comma as content rather than CSS #10898

Conversation

colin-grant-work
Copy link
Contributor

What it does

Modifies the approach taken to adding a comma between tail decorations to put it in the HTML markup rather than the CSS.

How to test

  1. Open a file and create some problems, then save it.
  2. See something like this in the navigator, with a comma:
    image
  3. Install GitLens, open the Branches tree view, and select one of the branches.
  4. See this:
    image

Not this (note funny commas):

image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the tree issues related to the tree (ex: tree widget) label Mar 17, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work well 👍

@colin-grant-work colin-grant-work merged commit 4326029 into eclipse-theia:master Mar 18, 2022
@colin-grant-work colin-grant-work deleted the bugfix/intrusive-commata branch March 18, 2022 16:45
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants