electron: fix electron global shortcuts #10869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit restores a fix that would previously remove the problematic `attachGlobalShortcuts` refactoring. The changes should now properly reload the application when necessary, and support commands such as recursive-search in the terminal. Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: Colin Grant <[email protected]>
vince-fugnitto
force-pushed
the
vf/fix-electron-reload
branch
from
e6a8c82
to
03e6efd
Compare
colin-grant-work
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Behavior post #10704 as been restored. Global shortcuts do not interfere with in-app shortcuts. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request restores the change #10704 which was re-introduced after #10600.
The goal of the pull-request is to remove the problematic
attachGlobalShortcutsmethod which caused the application to always interpret ctrl+r as a hard reload of the application despite having either a different context (ex: terminals), or updating keybinding.The change should now properly use the reload command which uses a proper context, and can be customized by end-users (
keymaps.json).How to test
Same as #10704:
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]
Co-authored-by: Colin Grant [email protected]