Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pinned Tabs #10817

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Add Pinned Tabs #10817

merged 7 commits into from
Mar 8, 2022

Commits on Mar 7, 2022

  1. Add ability to pin tabs 

    Add icons for pinned tabs
Add keybindings for pinning and unpinning tabs
Add a TODO notice for icons
Add activeEditorIsPinned context key
Add activeWidgetIsPinned context key while keeping vscode compatibility
Change pin/unpin commands to use activeWidgetIsPinned
Use VS Code command IDs for pin/unpin
Create TheiaTitle type
Refactor checks for pinning
Make preview editor non-preview when pinned
Unpin tab by clicking on icon
Fix reordering when unpinning
Do not rearrange tabs when pinned/unpinned
Make TheiaTitle a generic type

Co-authored-by: Colin Grant <[email protected]>
Co-authored-by: Dmitry Sharshakov <[email protected]>
    @dsseng @colin-grant-work
    dsseng and colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    86d77af View commit details
    Browse the repository at this point in the history

  2. fix side panel restoration

    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    be2eb0b View commit details
    Browse the repository at this point in the history

  3. switch to codicons

    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    283ae3e View commit details
    Browse the repository at this point in the history

  4. ensure view containers don't unpin themselves

    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    0d24681 View commit details
    Browse the repository at this point in the history

  5. nls issues

    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    223c372 View commit details
    Browse the repository at this point in the history

  6. Use correct context key

    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    eef3aeb View commit details
    Browse the repository at this point in the history

  7. extract utilities; ensure context key and command use same reference … 

    …widget
    @colin-grant-work
    colin-grant-work committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fe4cdf9 View commit details
    Browse the repository at this point in the history