vsx-registry: display incompatible extensions

[vince-fugnitto]

What it does

Fixes: #9676.

The commit adds the functionality to display incompatible extensions when performing a search. The changes will now display incompatible extensions but mark them as disabled, and non-installable. The behavior is also controllable by a new preference so users can decide if they want the potential extra noise when searching.

Example: using an api-version of 1.30.0:

How to test

1. start the application
2. open the extensions-view
3. perform a search - if an extension has no compatible version then it should be marked as disabled and non-installable
   3.1. hovering over the disabled extension should correctly display the tooltip
   3.2 the plugin should not resolve, the readme won't be displayed
4. updating the preference 'extensions.displayIncompatible' and re-searching should not yield incompatible results
5. repeat the steps by starting with yarn start --vscode-api-version=1.30.0 for additional incompatible results

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[msujew]

The behavior looks good to me:

• Incompatible version (tested this with API version 1.53.2 and 1.30.0) are shown but not installable.
• Switching the preference on/off correctly starts/stops displaying extensions with incompatible versions
• The visual changes work well with different themes.

I have a few suggestions regarding i18n though.

[colin-grant-work]

A few comments:

Functionality

• If you search for plugins and then change the preference, the current search result set doesn't change (the search isn't rerun). Particularly when moving from not showing -> showing, I think it would be better if the display did update.
• It seems that if a plugin is incompatible, you can't open an extension view widget for it to read its readme. That was unexpected, and seems undesirable.

Experience

Displaying a plugin that you can't interact with at all seems odd. Certainly it should be possible to open the extension view for it to see the readme, but I think it might also make sense to allow the user to install an incompatible plugin after a warning dialog that points out that the plugin may not work. Perhaps beyond the scope of this PR, but an excellent addition to it, if you're willing, would be to take the logic from #9330 to give the user the chance to select the oldest available version to install, in case that works better than the latest.

[vince-fugnitto]

Converted the pull-request to a draft in favor of completing #9330 first to get a better behavior in this pull-request 👍

[vince-fugnitto]

Moved the draft to my fork in the meantime vince-fugnitto#9.
The changes should be revisited once the following are completed:

• VSX: Add 'Install Another Version...' Command #9330
• Implement safe plugin uninstallation #11084