menu: update go main-menu

[vince-fugnitto]

What it does

The commit updates the go main-menu to add missing items used for navigation, location, language-features and problems.

How to test

1. start the browser or electron example application
2. confirm the go menu is correct
3. confirm that the menu items based on the available commands work well

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[msujew]

LGTM, I can confirm that the added menu entries work as expected and are grouped/ordered as they are in vscode 👍

[msujew]

Due to the merge of #10106, I'd recommend to add the appropriate nls.localize calls with the respective vscode IDs.

[vince-fugnitto]

Due to the merge of #10106, I'd recommend to add the appropriate nls.localize calls with the respective vscode IDs.

@msujew ehh...I did not expect the codebase to have so much noise as we now reference vscode everywhere:

I have a few follow-up questions:

• how are we expected to find these keys (no documentation for developers or in coding guidelines)
• I don't see anything that helps developers remember to localize - syntax help, warnings
• What should we localize (falls under the documenation)
• What do we do in case the commands, menus, preferences have no vscode counterpart?

I think without all these in place it makes handling localization going forward difficult.

[msujew]

ehh...I did not expect the codebase to have so much noise as we now reference vscode everywhere:

@vince-fugnitto I feel like localization in general is a lot of noise, I noticed that as well when looking at the codebase of vscode.

Regarding your questions: I already have some stuff prepared for the coding guidelines (in regards to how and what to localize), which I will add tomorrow and improve over the coming days. I also have something planned for developers to have an easier time finding keys that already exist inside of the vscode language packs.

I don't see anything that helps developers remember to localize - syntax help, warnings

This is probably the one that's the hardest to deal with, as programmatically identifying which strings are shown to the user and which ones aren't is quite impossible. I'll keep that issue in mind and see what I can do.

What do we do in case the commands, menus, preferences have no vscode counterpart?

That will also be included in the coding guidelines. In short: Write a nls.localize('theia/<package>/<id>', '<value>') call. The new id and the corresponding default value will be picked up by the appropriate theia-cli command and translated into different languages later on (hopefully completely automatically).

[vince-fugnitto]

@msujew

@vince-fugnitto I feel like localization in general is a lot of noise, I noticed that as well when looking at the codebase of vscode.

I don't mean so much the noise of all the .localize calls, but rather than the entire codebase now refers to vscode and now needs to be coupled with their keys which we now need to find which I'm not sure is trivial or not. Given that language-packs are in fact plugins I did not expect all the functionality to bleed to the rest of the framework.

We are a framework, and we are Eclipse Theia not VS Code so I did not expect to have references of internals of vscode everywhere.

That will also be included in the coding guidelines. In short: Write a nls.localize('theia/<package>/<id>', '<value>') call. The new id and the corresponding default value will be picked up by the appropriate theia-cli command and translated into different languages later on (hopefully completely automatically).

There are many commands I assume already in the framework which have no vscode counterpart, are these handled today or are simply not localized yet?

[msujew]

We are a framework, and we are Eclipse Theia not VS Code so I did not expect to have references of internals of vscode everywhere.

I see, that's understandable. I'll think about how we could reduce our tight coupling with vscode.

There are many commands I assume already in the framework which have no vscode counterpart, are these handled today or are simply not localized yet?

They're currently not localized. Around 15% of user-facing strings in Theia (there only a bit more than a thousand of them in total) are not translated, mainly in the custom views that do not exist inside of vscode (like the properties view, scm amend, scm history, etc.). For the actual translation, if I recall correcly, @brianking proposed during a dev-meeting to have manual reviewers/contributors for each supported language which utilize the machine-translations (generated by the appropriate CLI commands). I'll start to work on this next.

[msujew]

I am currently working on tooling to improve finding translation keys... :/

[msujew]

LGTM, merge at your own discretion 👍

[colin-grant-work]

I ran every command. It seems 'Go to declaration' didn't work in either Theia or VScode for TypeScript, but otherwise all executed successfully. I also installed the Chinese (Traditional) language pack and observed that all of the commands in the menu were translated.

[colin-grant-work]

@msujew, while I was testing this, I installed a language pack and then switched to that language, and everything went well. Then I experienced a bug that shut the application down, and when I restarted it, everything was in English again. I tried running the 'Configure Display Language' command to switch back, but when I selected Chinese, nothing happened. Selecting English again caused a refresh, then everything was in English again, and then I could select Chinese and produce a refresh. However, shutting things down and restarting got me back to English again, with selecting Chinese doing nothing. Is this a known issue, or should I create one?

[msujew]

@colin-grant-work Interesting, please go ahead and create an issue for that. I should have time tomorrow to work on fixing this.