Add dynamic debug configurations API #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsan09
added
debug
packages/plugin-ext/src/main/browser/debug/plugin-debug-service.ts
Outdated
Show resolved
Hide resolved
alvsan09
force-pushed
the
asl/add-dynamic-debug-config-api
branch
from
d652bb2
to
8ba8e81
Compare
|
commit 8ba8e81 is just a re-base to later master, |
|
This seems to be working for the most part. I did run into a few minor issues:
Otherwise things are looking good. Very nice work. |
|
Re: hovers, when using the trace configuration, the logging indicates that the hover request is being sent and processed successfully, but no hover appears:
|
That's right, I have adjusted the mock debugger to help with the testing of dynamic debug configurations although as you have noticed there is still work to do to have it fully working with
Thanks !! 👍 |
Hovering is not yet supported via the mock debug, although that does not prevent the verification of dynamic debug configurations. |
colin-grant-work
approved these changes
Sep 21, 2021
packages/plugin-ext/src/main/browser/debug/plugin-debug-adapter-contribution.ts
Outdated
Show resolved
Hide resolved
alvsan09
force-pushed
the
asl/add-dynamic-debug-config-api
branch
from
01d9e0e
to
e72dcad
Compare
packages/plugin-ext/src/main/browser/debug/plugin-debug-service.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/debug/plugin-debug-service.ts
Outdated
Show resolved
Hide resolved
This initial implementation provides dynamic debug configurations via the quick pick command palette. e.g. ctrlcmd+p -> type 'debug ' (Note the space at the end). if an extension provider of dynamic debug configurations is loaded, these entries are listed and available for selection. Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09
force-pushed
the
asl/add-dynamic-debug-config-api
branch
from
e571eeb
to
404e797
Compare
|
The last commit is a re-base to master. |
vince-fugnitto
approved these changes
Sep 28, 2021
This was referenced Oct 1, 2021
alvsan09
added a commit
that referenced
this pull request
Oct 26, 2021
Following the recent support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries will be directly available to the user, showing them with the name and suffixed by the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently used dynamic debug configurations so they will still be presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered - Focus is gained or lost by the configuration selection box Refreshing these configurations allows to present up to date dynamic configurations, e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. - When a new provider extension has just been loaded. Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Nov 22, 2021
Following the recent support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries will be directly available to the user, showing them with the name and suffixed by the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently used dynamic debug configurations so they will still be presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered - Focus is gained or lost by the configuration selection box Refreshing these configurations allows to present up to date dynamic configurations, e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. - When a new provider extension has just been loaded. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Nov 22, 2021
Following the recent support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries will be directly available to the user, showing them with the name and suffixed by the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently used dynamic debug configurations so they will still be presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered - Focus is gained or lost by the configuration selection box Refreshing these configurations allows to present up to date dynamic configurations, e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. - When a new provider extension has just been loaded. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Nov 30, 2021
Following the recent support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries will be directly available to the user, showing them with the name and suffixed by the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently used dynamic debug configurations so they will still be presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered - Focus is gained or lost by the configuration selection box Refreshing these configurations allows to present up to date dynamic configurations, e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. - When a new provider extension has just been loaded. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Dec 14, 2021
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Dec 14, 2021
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Dec 18, 2021
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jan 12, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jan 12, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jan 21, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jan 31, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Feb 18, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Apr 4, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Apr 4, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Apr 20, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
May 20, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
May 26, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
May 26, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jun 1, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jun 1, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jun 1, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jun 1, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
alvsan09
added a commit
that referenced
this pull request
Jun 1, 2022
Following the support for dynamic debug configurations via command Debug: Select and Start debugging. PR #10134 This change extends the functionality further to bring provided dynamic debug configurations to the list of available configurations under the debug view. The user can select these dynamic configurations by first selecting the debug type and a quick pick input box will follow to allow the selection from the available configurations of the selected type. Once a dynamic configuration has been selected it will be added to a short list (limited to 3) of recently used dynamic debug configurations, these entries are available to the user, rendered with the name and suffixed with the debug type in parenthesis. This will facilitate subsequent selection / execution. This change additionally preserves and restores the list of recently selected dynamic debug configurations so they are presented in subsequent sessions. These configurations are refreshed from the providers when: - Configuration providers are registered or unregistered - Focus is gained or lost by the configuration selection box Refreshing these configurations intends to render valid dynamic configurations to the current context. e.g. - Honoring an extension 'when' clause to a file with a specific extension opened in the active editor. However there are situations where the context for execution of a dynamic configuration may no longer be valid e.g. - The configuration is restored from a previous session and the currently selected file is not supported. - The switch of context may not have involved a refresh of dynamic debug configurations. (e.g. switching active editors, etc.) Considering the above, execution of dynamic configurations triggers the fetch of dynamic configurations for the selected provider type, if the configuration is no longer provided, the user will be notified of a missing configuration or not applicable to the current context. Signed-off-by: Alvaro Sanchez-Leon <[email protected]> Co-authored-by: Paul Marechal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8652
This initial implementation exposes plugin provided dynamic debug configurations via the quick pick command palette.
e.g.
ctrlcmd+p -> type 'debug ' (Note the space at the end).or alternatively:
ctrl+shft+p -> type 'Select and start debugging'If an extension provider of dynamic debug configurations is loaded, these entries are listed and available for selection.
How to test
#Alternative 1
ms-vscode.js-debugis installed as a builtin dependencyOpen a
javascriptortypescriptproject, build it and open in editor a.jsor.tsfile ready to be debugged.pwa-nodedebug type,Select the one called
Run current fileNOTE: The dynamic configuration 'Create JavaScript debug terminal', does not work properly, this will be tracked in the following issue #9978.
#Alternative 2 (For a more in depth testing and development)
The following URL points to a fork repository of
vscode-mock-debug, and thetheia-dynamic-debugbranch is provided for test purposes of this functionality.theiadevelopment repository install thevscode-mock-debugextension inside thepluginsfolder via the following commands:select one of the provided dynamic configurations under
mock:Example:
Review checklist
Reminder for reviewers
Signed-off-by: Alvaro Sanchez-Leon [email protected]