Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[markers] update problem-marker decorators similar to vscode #3819

Closed
vince-fugnitto opened this issue Dec 12, 2018 · 0 comments · Fixed by #10820
Closed

[markers] update problem-marker decorators similar to vscode #3819

vince-fugnitto opened this issue Dec 12, 2018 · 0 comments · Fixed by #10820
Labels
markers issues related to problem markers proposal feature proposals (potential future features) question user / developer questions

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Dec 12, 2018 •
edited
Loading

just a question, should we be decorate the navigator from the problem-decorator similar to vscode? Currently we use the iconOverlay to display a small circle with an x in it, but should we improve the decorator to be similar to vscode?

I made the following poc:

Screen Shot 2020-03-30 at 12 17 35 PM
@vince-fugnitto vince-fugnitto added question user / developer questions markers issues related to problem markers proposal feature proposals (potential future features) labels Dec 12, 2018
@vince-fugnitto vince-fugnitto mentioned this issue Jan 7, 2020
Closed
1 task
vince-fugnitto added a commit that referenced this issue Mar 31, 2020
@vince-fugnitto
markers: update the problem-marker decoration
4ad8b1a 
Fixes #3819

The following commit updates the `problem-marker` decoration from
the `explorer` to display the total count of errors and warnings for a given resource
and updates container nodes (parent directories) to display a generic symbol. The
following changes are aligned with the behavior with VS Code.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto mentioned this issue Mar 31, 2020
Closed
1 task
@vince-fugnitto vince-fugnitto mentioned this issue Mar 1, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
markers issues related to problem markers proposal feature proposals (potential future features) question user / developer questions
Projects
None yet
Milestone
No milestone
1 participant
@vince-fugnitto