Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Settings in Huggingface Provider are broken #14503

Closed
JonasHelming opened this issue Nov 23, 2024 · 0 comments · Fixed by #14504
Closed

Request Settings in Huggingface Provider are broken #14503

JonasHelming opened this issue Nov 23, 2024 · 0 comments · Fixed by #14504

Comments

@JonasHelming
Copy link
Contributor

The Hugging Face Provider does not respect settings from the request. Also, it only allows one fixed stop word.
@JonasHelming JonasHelming changed the title Request Settings in Huggingface Provider are brokwn Request Settings in Huggingface Provider are broken Nov 23, 2024
JonasHelming added a commit that referenced this issue Nov 23, 2024
@JonasHelming
Fix request settings and stop words in HF provider
fdbae15 
fixed #14503

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming mentioned this issue Nov 23, 2024
Merged
1 task
JonasHelming added a commit that referenced this issue Nov 26, 2024
@JonasHelming
Fix request settings and stop words in HF provider
359f3be 
fixed #14503

Signed-off-by: Jonas Helming <[email protected]>
JonasHelming added a commit that referenced this issue Nov 28, 2024
@JonasHelming @sdirix
Add support for users to specify custom request settings, model and o…
1301b45 
…ptionally provider specific (#14535)

* Fix request settings and stop words in HF provider

fixed #14503

Signed-off-by: Jonas Helming <[email protected]>
Co-authored-by: Stefan Dirix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix request settings and stop words in HF provider eclipse-theia/theia
1 participant
@JonasHelming