Running command in terminal cannot be canceled

[sgraband]

Bug Description:

Currently it seems like ctrl-c is not properly forwarded/registered on the built-in terminal. Pressing the keys does not cancel the currently running command.

Steps to Reproduce:

1. Open a terminal
2. Run a long-running command (e.g. yarn start)
3. Try to cancel the command with ctrl-c
4. Observe that the command i s not cancelled.

Additional Information

• Operating System: Ubuntu 22.04
• Theia Version: Theia IDE 1.48.0 (preview)

[tsmaeder]

I suspect this change is responsible for the problem: https://github.com/eclipse-theia/theia/pull/13493/files#diff-9d5279a0f960f7a97475073be510df0dcff9e33cf65830eb7205eb1c7ee96caaR42

[tsmaeder]

Turns out, this has nothing to do with the above change. There are several keybindings for ctrl-c the keybindings are traversed in registration order (per scope) and the first one that matches and is enabled is returned. In this case, it's copy (set core/browser/keybinding.ts#matchKeybinding(). If this ever worked, it's by accident.

[tsmaeder]

While the above statement is true, the change in behavior is due to a different commit: https://github.com/eclipse-theia/theia/pull/13497/files#diff-549a2a9faed260a01fce0f2c2c3f3c4167d3fed2181fcd0bbc7a39b996082437R500

The "passthrough" pseudo-command has no handler and therefore is never enabled.