Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Browse" button for file preferences obscures part of the input field #12582

Closed
w-pearson opened this issue May 30, 2023 · 2 comments · Fixed by #12586
Closed

"Browse" button for file preferences obscures part of the input field #12582

w-pearson opened this issue May 30, 2023 · 2 comments · Fixed by #12586
Labels
preferences issues related to preferences ui/ux issues related to user interface / user experience

Comments

@w-pearson
Copy link
Contributor

Bug Description:

The "browse" button on file inputs covers part of the text field. For long paths, it is impossible to scroll the field to show the end.

image

This could be solved either by making the input field smaller or moving the browse button to the right. (It's also possible to set padding-right: 5.5em or something like that to preserve the same look, but I think that'd just lead to more confusion for no real benefit.)

Steps to Reproduce:

This can be reproduced using Theia Blueprint:

  1. Launch Theia Blueprint
  2. Open file -> preferences -> settings
  3. Search for "Windows"
  4. Under "Terminal > External: Windows Exec", type additional characters so that the text box is full.
  5. Observe that the "browse" button hides part of the text field, and it is impossible to scroll that part to be visible using end or the right arrow.

This affects any preference with isFilepath: true, although this is the only built-in preference using that.

Additional Information

  • Operating System: Windows
  • Theia Version: 1.37.0 (also tested 1.34.2)
@vince-fugnitto vince-fugnitto added preferences issues related to preferences ui/ux issues related to user interface / user experience labels May 31, 2023
@vince-fugnitto
Copy link
Member

@w-pearson we can probably simplify it to just displaying the button after the input rather than inside if you're interested in contributing a pull-request:

For example:

image

@w-pearson
Copy link
Contributor Author

Yeah, that sounds good. I'll look into creating a pull request later today.

w-pearson added a commit to w-pearson/theia that referenced this issue Jun 1, 2023
@w-pearson
Don't cover input field with file preference browse button
9dfaddb 
Fixes eclipse-theia#12582. The button is now next to the input field instead of on top of it, and thus the button does not cover the end of the input field for long paths.

Signed-off-by: William Pearson <[email protected]>
@w-pearson w-pearson mentioned this issue Jun 1, 2023
Merged
1 task
martin-fleck-at pushed a commit that referenced this issue Jul 3, 2023
@w-pearson
Don't cover input field with file preference browse button (#12586)
828b899 
The button is now next to the input field instead of on top of it, and thus the button does not cover the end of the input field for long paths.

Fixes #12582. 

Signed-off-by: William Pearson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
preferences issues related to preferences ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't cover input field with file preference browse button w-pearson/theia
2 participants
@vince-fugnitto @w-pearson