-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secondary-window: add support for additional views besides webviews #11643
Comments
I'm working on supporting the terminal in a scondary window. The first problem I ran into is not having the proper style information inside the secondary window. My approach would be to have a webpack build that generates the "index.html" and associated *.css files using https://github.com/webpack-contrib/mini-css-extract-plugin. |
One more problem I've run into is that opening the "find" dialog does not work: keybindings only listen on events in the main window. Not sure yet what the right approach is here. |
I'm also running into a single-window assumption in PhosphorJS when I attach/detach a widget: the widget search box is attached/detached from the terminal window in TerminalWidgetImpl.onBeforeAttach(). The code that borks is in PhosphorJS's `widget.js":
Note that the document global in |
This work is happening in the context of eclipse-theia#11643 The main changes are - Add support for building a "secondary-window.css" file to load in the secondary window. Includes markup for marking frontend modules as contributing to the sceondary windows - Add keybinding listeners to secondary windows - Add color variables to secondary window style (theme support) - monkey-patch IntersectionObserver handling on Firefox to make terminal refresh when in secondary window - Extend PhosphorJS source patching to work for widget attach/detach Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
This work is happening in the context of eclipse-theia#11643 The main changes are - Add support for building a "secondary-window.css" file to load in the secondary window. Includes markup for marking frontend modules as contributing to the sceondary windows - Add keybinding listeners to secondary windows - Add color variables to secondary window style (theme support) - monkey-patch IntersectionObserver handling on Firefox to make terminal refresh when in secondary window - Extend PhosphorJS source patching to work for widget attach/detach Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
This work is happening in the context of eclipse-theia#11643 The main changes are - Add support for building a "secondary-window.css" file to load in the secondary window. Includes markup for marking frontend modules as contributing to the sceondary windows - Add keybinding listeners to secondary windows - Add color variables to secondary window style (theme support) - monkey-patch IntersectionObserver handling on Firefox to make terminal refresh when in secondary window - Extend PhosphorJS source patching to work for widget attach/detach Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
* Add secondary window support for terminals This work is happening in the context of #11643 The main changes are - Add support for building a "secondary-window.css" file to load in the secondary window. Includes markup for marking frontend modules as contributing to the sceondary windows - Add keybinding listeners to secondary windows - Add color variables to secondary window style (theme support) - monkey-patch IntersectionObserver handling on Firefox to make terminal refresh when in secondary window - Extend PhosphorJS source patching to work for widget attach/detach Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
Feature Description:
The goal is to enhance #11048 and add support for additional views besides
webviews
. The current implementation only supports webviews which are a minor feature in the framework, and we should enhance support to include:scm
,debug
)The text was updated successfully, but these errors were encountered: