tests

examples/api-tests/src/saveable.spec.js

@@ -33,6 +33,7 @@ describe('Saveable', function () {
     const { Disposable, DisposableCollection } = require('@theia/core/lib/common/disposable');
 
     const container = window.theia.container;
+    /** @type {EditorManager} */
     const editorManager = container.get(EditorManager);
     const workspaceService = container.get(WorkspaceService);
     const fileService = container.get(FileService);
@@ -266,6 +267,17 @@ describe('Saveable', function () {
         assert.equal(state.value.trimRight(), 'bar', 'fs should be updated');
     });
 
+    it('no save prompt when multiple editors open for same file', async () => {
+        const secondWidget = await editorManager.openToSide(fileUri);
+        editor.getControl().setValue('two widgets');
+        assert.isTrue(Saveable.isDirty(widget), 'the first widget should be dirty');
+        assert.isTrue(Saveable.isDirty(secondWidget), 'the second widget should also be dirty');
+        await Promise.resolve(secondWidget.close());
+        assert.isTrue(secondWidget.isDisposed, 'the widget should have closed without requesting user action');
+        assert.isTrue(Saveable.isDirty(widget), 'the original widget should still be dirty.');
+        assert.equal(editor.getControl().getValue(), 'two widgets', 'should still have the same value');
+    });
+
     it('normal close', async () => {
         editor.getControl().setValue('bar');
         assert.isTrue(Saveable.isDirty(widget), 'should be dirty before before close');

packages/core/src/browser/saveable.ts

@@ -125,7 +125,7 @@ export namespace Saveable {
                     if (result) {
                         await Saveable.save(this);
                     }
-                    await this.closeWithoutSaving(result);
+                    await this.closeWithoutSaving();
                 }
             } finally {
                 closing = false;

packages/core/src/browser/shell/application-shell.ts

@@ -1445,8 +1445,7 @@ export class ApplicationShell extends Widget {
      * @return an array of all the widgets that were actually closed.
      */
     async closeMany(targets: Widget[], options?: ApplicationShell.CloseOptions): Promise<Widget[]> {
-        const others = this.widgets.filter(widget => !targets.includes(widget));
-        if (options?.save === false || await Saveable.confirmSaveBeforeClose(targets, others)) {
+        if (options?.save === false || await Saveable.confirmSaveBeforeClose(targets, this.widgets.filter(widget => !targets.includes(widget)))) {
             return (await Promise.all(targets.map(target => this.closeWidget(target.id, options)))).filter((widget): widget is Widget => widget !== undefined);
         }
         return [];