Skip to content

Commit

Permalink
core: remove maximize with double-click
Browse files Browse the repository at this point in the history
The commit removes the problematic `maximize` functionality when
performing a double-click of a tabbar. This behavior aligns with vscode.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Jun 9, 2022
1 parent 57f6415 commit 859d1db
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/core/src/browser/shell/tab-bars.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ export class TabBarRenderer extends TabBar.Renderer {
{
key, className, id, title: title.caption, style, dataset,
oncontextmenu: this.handleContextMenuEvent,
ondblclick: this.handleDblClickEvent,
onauxclick: (e: MouseEvent) => {
// If user closes the tab using mouse wheel, nothing should be pasted to an active editor
e.preventDefault();
Expand Down Expand Up @@ -482,6 +481,10 @@ export class TabBarRenderer extends TabBar.Renderer {
}
};

/**
* @deprecated since 1.27.0.
* The framework no longer maximizes tabbars when performing a double-click.
*/
protected handleDblClickEvent = (event: MouseEvent) => {
if (this.tabBar && event.currentTarget instanceof HTMLElement) {
const id = event.currentTarget.id;
Expand Down

0 comments on commit 859d1db

Please sign in to comment.