Quit Electron app when back end fails to start. Fixes #12769

Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
eclipse-theia · Jul 28, 2023 · 3f8c4db · 3f8c4db
1 parent 6607185
commit 3f8c4db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dev-packages/application-manager/src/generator/backend-generator.ts b/dev-packages/application-manager/src/generator/backend-generator.ts
@@ -90,6 +90,7 @@ module.exports = Promise.resolve()${this.compileElectronMainModuleImports(electr
         if (reason) {
             console.error(reason);
         }
+        app.quit();
     });
 `;
     }

diff --git a/packages/core/src/electron-main/electron-main-application.ts b/packages/core/src/electron-main/electron-main-application.ts
@@ -507,6 +507,9 @@ export class ElectronMainApplication {
                 backendProcess.on('error', error => {
                     reject(error);
                 });
+                backendProcess.on('exit', () => {
+                    reject(new Error('backend process exited'));
+                })
                 app.on('quit', () => {
                     // Only issue a kill signal if the backend process is running.
                     // eslint-disable-next-line no-null/no-null
-Original file line number
+Diff line change
@@ Expand Up @@
             if (reason) {
                 console.error(reason);
             }
+            app.quit();
         });
     `;
         }
@@ Expand Down @@