Creating new untitled document doesn't work

eclipse-theia · Aug 9, 2024 · 0dbb92c · 0dbb92c
1 parent 44d42ec
commit 0dbb92c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/notebook/src/browser/service/notebook-model-resolver-service.ts b/packages/notebook/src/browser/service/notebook-model-resolver-service.ts
@@ -18,7 +18,7 @@ import { Emitter, Resource, ResourceProvider, UNTITLED_SCHEME, URI } from '@thei
 import { inject, injectable } from '@theia/core/shared/inversify';
 import { UriComponents } from '@theia/core/lib/common/uri';
 import { FileService } from '@theia/filesystem/lib/browser/file-service';
-import { NotebookData } from '../../common';
+import { CellKind, NotebookData } from '../../common';
 import { NotebookModel } from '../view-model/notebook-model';
 import { NotebookService } from './notebook-service';
 import { NotebookTypeRegistry } from '../notebook-type-registry';
@@ -111,7 +111,14 @@ export class NotebookModelResolverService {
     async resolveExistingNotebookData(resource: Resource, viewType: string): Promise<NotebookData> {
         if (resource.uri.scheme === 'untitled') {
             return {
-                cells: [],
+                cells: [
+                    {
+                        cellKind: CellKind.Code,
+                        language: 'plaintext',
+                        source: 'Untitled notebook',
+                        outputs: []
+                    }
+                ],
                 metadata: {}
             };
         } else {

diff --git a/packages/plugin-ext/src/main/browser/notebooks/notebook-documents-main.ts b/packages/plugin-ext/src/main/browser/notebooks/notebook-documents-main.ts
@@ -159,11 +159,6 @@ export class NotebookDocumentsMainImpl implements NotebookDocumentsMain {
         // untitled notebooks are dirty by default
         this.proxy.$acceptDirtyStateChanged(ref.uri.toComponents(), true);
 
-        // apply content changes... slightly HACKY -> this triggers a change event
-        if (options.content) {
-            const data = NotebookDto.fromNotebookDataDto(options.content);
-            ref.setData(data);
-        }
         return ref.uri.toComponents();
     }