Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for enhanced tab bar preview #411

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

sgraband
Copy link
Contributor

Documentation for the feature introduced with eclipse-theia/theia#12350

Contributed on behalf of STMicroelectronics

sgraband and others added 2 commits April 14, 2023 14:47
Documentation for the feature introduced with eclipse-theia/theia#12350

Contributed on behalf of STMicroelectronics
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look good overall! I added a commit with some longer suggestions, and then made a few more minor suggestions inline. Let me know what you think @sgraband.

src/docs/enhanced_tab_bar_preview.md Outdated Show resolved Hide resolved
src/docs/enhanced_tab_bar_preview.md Outdated Show resolved Hide resolved
src/docs/enhanced_tab_bar_preview.md Outdated Show resolved Hide resolved
@sgraband
Copy link
Contributor Author

Thank you for the changes @planger! They look good to me. I added a commit with the in-line changes.

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sgraband! This looks fine to me now.
@vince-fugnitto Would you be able to look at the proposal? Thank you in advance!

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@planger planger merged commit d12100d into eclipse-theia:master Apr 17, 2023
@planger planger deleted the enhancedTabBarPreview branch April 17, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants