Remove timers import from node and use from Window instead #273 #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #273 by removing imports from node. The required functions are available on
Window
as well.https://developer.mozilla.org/en-US/docs/Web/API/setInterval
https://developer.mozilla.org/en-US/docs/Web/API/clearInterval
Contributed on behalf of STMicroelectronics
Signed-off-by: Johannes Faltermeier [email protected]
How to test
applications/electron/package.json
to e.g.1.39.1
yarn && yarn electron package
applications/electron/dist
directory to some other locationnpx serve -d -u -p 5000
in the copied dist directory to serve this build as a potential updateurl
s inapplications/electron/electron-builder.yml
tohttp://localhost:5000
yarn && yarn electron package
again (this time building an app with version 1.39.0)Review checklist
Reminder for reviewers