Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timers import from node and use from Window instead #273 #285

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jul 20, 2023

What it does

Fixes #273 by removing imports from node. The required functions are available on Window as well.

https://developer.mozilla.org/en-US/docs/Web/API/setInterval
https://developer.mozilla.org/en-US/docs/Web/API/clearInterval

Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier [email protected]

How to test

  1. First increase version in applications/electron/package.json to e.g. 1.39.1
  2. yarn && yarn electron package
  3. Copy applications/electron/dist directory to some other location
  4. Run npx serve -d -u -p 5000 in the copied dist directory to serve this build as a potential update
  5. Undo the change from step 1
  6. Update the urls in applications/electron/electron-builder.yml to http://localhost:5000
  7. Run yarn && yarn electron package again (this time building an app with version 1.39.0)
  8. Start the built 1.39.0 application and check whether the update works again.

Review checklist

Reminder for reviewers

Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier <[email protected]>
@jfaltermeier jfaltermeier marked this pull request as ready for review July 20, 2023 11:13
@jfaltermeier jfaltermeier merged commit 8b5fac9 into master Jul 28, 2023
@jfaltermeier jfaltermeier deleted the jf/updater-fix branch July 28, 2023 08:46
@jfaltermeier jfaltermeier mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron can't download update.
2 participants