Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: maximum callstack exceeded errors due to msgpackr #265

Open
vince-fugnitto opened this issue May 29, 2023 · 3 comments
Open

bug: maximum callstack exceeded errors due to msgpackr #265

vince-fugnitto opened this issue May 29, 2023 · 3 comments
Labels
bug bugs found in the application

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

There is an issue following 6ddc6e3 where the upgrade to msgpackr is causing maximum callstack exceeded errors due to eclipse-theia/theia#12499. We added a resolution note in the main repo as a workaround until fixed:

rpc-message-encoder.ts:151 Uncaught (in promise) Error: Error during encoding: 'Maximum call stack size exceeded'
    at t.MsgPackMessageEncoder.encode (rpc-message-encoder.ts:151:23)
    at t.MsgPackMessageEncoder.request (rpc-message-encoder.ts:137:14)
    at l.sendRequest (rpc-protocol.ts:161:22)
    at proxy-handler.ts:74:45

https://github.com/eclipse-theia/theia-blueprint/blob/5850adb9220e3cea711ebcf4ef89852c7720778e/yarn.lock#L9567-L9568

Steps to Reproduce:

  1. start the application
  2. notice the maximum callstack exceeded logs

Additional Info

@badrihcl
Copy link

The mentioned workaround works and exception isn't thrown . But we still have the connection issue as mentioned in eclipse-theia/theia#12574.

The issue occurs only with Theia Blueprint 1.37 and not with Theia Blueprint 1.36 for the same vscode extension.

image

Should I raise a separate defect for this ?

@vince-fugnitto
Copy link
Member Author

@badrihcl I don't have an environment to test, if you can debug as to why it happens first that would be helpful.

jfaltermeier added a commit that referenced this issue Jun 1, 2023
jfaltermeier added a commit that referenced this issue Jun 2, 2023
Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier <[email protected]>
jfaltermeier added a commit that referenced this issue Jun 7, 2023
Contributed on behalf of STMicroelectronics

Signed-off-by: Johannes Faltermeier <[email protected]>
@marcdumais-work
Copy link
Contributor

@badrihcl Can you try with Blueprint 1.38.0, that we recently made available? It pins msgpackr to an earlier version, known to work.

image

Also, it seems that msgpackr has a new version out that contains a fix: 1.9.5. Let us know if you still have the issue with Blueprint 1.38.0, and maybe we can upgrade its msgpackr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application
Projects
None yet
Development

No branches or pull requests

3 participants