Jiden/create generator sprotty 257 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
generated app now runs Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
spoenemann
reviewed
Feb 15, 2023
| }, | ||
| "devDependencies": { | ||
| "typescript": "4.9.5", | ||
| "esbuild": "^0.17.8" |
There was a problem hiding this comment.
Shall we add http-server and a start script?
There was a problem hiding this comment.
im not sure if we should. The example works with just opening the html file so i don't really see the need to add more dependencies that the user needs to remove later again when he wants to use the project for something else
Signed-off-by: Jonah Iden <[email protected]>
gfontorbe
reviewed
Feb 20, 2023
packages/generator-sprotty/sprotty-local-template/src/views.tsx
Outdated
Show resolved
Hide resolved
gfontorbe
reviewed
Feb 20, 2023
|
do you mean because of the "test-temp/"? |
Signed-off-by: Jonah Iden <[email protected]>
spoenemann
reviewed
Feb 24, 2023
packages/generator-sprotty/sprotty-local-template/static/styles.css
Outdated
Show resolved
Hide resolved
packages/generator-sprotty/sprotty-local-template/static/index.html
Outdated
Show resolved
Hide resolved
nicer formatted output for generator, less agressiv colors for example, fixed indentation, rinraf instead of shx Signed-off-by: Jonah Iden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #257
this implements a basic version of a yeoman generator for sprotty.
The example application this generator creats is based on the getting started example from gfontorbe/sprotty-website#1
How to test
yarnyarn buildnpm linkyarn run run