Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lose selection when clicking over root #341

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Don't lose selection when clicking over root #341

merged 1 commit into from
Feb 14, 2023

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Feb 13, 2023 •
edited
Loading

How to verify:

  • select one or more elements in an example project
  • pan with the mouse - selection should remain the same
  • click the root area - selection should be reseted

@dhuebner dhuebner force-pushed the dh/select-handling-302 branch from 8a9044e to d7a8d3d Compare February 13, 2023 12:13
spoenemann
spoenemann approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhuebner dhuebner merged commit 584a701 into master Feb 14, 2023
@dhuebner dhuebner deleted the dh/select-handling-302 branch February 14, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@tortmayr tortmayr Awaiting requested review from tortmayr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuebner @spoenemann