Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fail() calls in several ResourceTest implementations #903 #913

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

HeikoKlare
Copy link
Contributor

  • Removes unnecessary try-catch blocks or replaces them with assertThrows statements
  • Throw exceptions instead of calling fail()
  • Remove unnecessary cleanup functionality

Contributes to #903

…platform#903

* Removes unnecessary try-catch blocks or replaces them with
assertThrows statements
* Throw exceptions instead of calling fail()
* Remove unnecessary cleanup functionality

Contributes to
eclipse-platform#903
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Test Results

     591 files  ±0       591 suites  ±0   1h 15m 9s ⏱️ + 9m 58s
  3 842 tests ±0    3 837 ✔️ +1    5 💤 ±0  0  - 1 
12 132 runs  ±0  12 096 ✔️ +1  36 💤 ±0  0  - 1 

Results for commit 7fbc47c. ± Comparison against base commit bf5a19d.

@HeikoKlare HeikoKlare marked this pull request as ready for review December 4, 2023 14:09
@HeikoKlare HeikoKlare merged commit 9b3c91d into eclipse-platform:master Dec 4, 2023
16 checks passed
@HeikoKlare HeikoKlare deleted the cleanup-tests branch December 4, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant