Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate and restructure resources watson tests to JUnit 5 #903 #1554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate and restructure resources watson tests to JUnit 5 #903 #1554

wants to merge 1 commit into from

Conversation

HeikoKlare
Copy link
Contributor

Migrates the tests in org.eclipse.core.tests.internal.watson to JUnit 5.

  • Exchange JUnit 4 test annotations
  • Replace JUnit 4 assertions with JUnit 5 or AssertJ assertions
  • Restructure the tests: replace misused inheritance with helper class, replace polymorphic with imperative behavior specification, and parameterize tests

Contributes to #903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

Test Results

 1 734 files  +  405   1 734 suites  +405   1h 24m 51s ⏱️ + 21m 5s
 4 156 tests +  177   4 134 ✅ +  178   22 💤  -  1  0 ❌ ±0 
13 065 runs  +3 465  12 901 ✅ +3 404  164 💤 +61  0 ❌ ±0 

Results for commit 0d63fd6. ± Comparison against base commit e3664ce.

This pull request removes 4 and adds 181 tests. Note that renamed tests count towards both. 
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests DeltaFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests TreeFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests TreeFlatteningTest ‑ testExhaustive

AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[10] /solution/project1, 2
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[11] /solution/project1, 3
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[12] /solution/project1, 4
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[13] /solution/project2, -1
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[14] /solution/project2, 0
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[15] /solution/project2, 1
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[16] /solution/project2, 2
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[17] /solution/project2, 3
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[18] /solution/project2, 4
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[19] /solution/project2/folder1, -1
…

♻️ This comment has been updated with latest results.

@HeikoKlare
Migrate and restructure resources watson tests to JUnit 5 eclipse-pla…
0d63fd6 
…tform#903

Migrates the tests in org.eclipse.core.tests.internal.watson to JUnit 5.
- Exchange JUnit 4 test annotations
- Replace JUnit 4 assertions with JUnit 5 or AssertJ assertions
- Restructure the tests: replace misused inheritance with helper class,
replace polymorphic with imperative behavior specification, and
parameterize tests

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare marked this pull request as ready for review September 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeikoKlare