Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary casts #1438

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

stephan-herrmann
Copy link
Contributor

When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.

With this PR I suggest to remove affected casts before new errors/warnings will show up in the build.

@akurtakov
Copy link
Member

Version bumps required:

  • Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.8:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.team.core: Only qualifier changed for (org.eclipse.team.core/3.10.400.v20240620-1546). Expected to have bigger x.y.z than what is available in baseline (3.10.400.v20240413-1529) -> [Help 1]
  • Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.8:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.help.ui: Only qualifier changed for (org.eclipse.help.ui/4.7.0.v20240620-1546). Expected to have bigger x.y.z than what is available in baseline (4.7.0.v20240414-1916) -> [Help 1]

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Test Results

 1 705 files   -  29   1 705 suites   - 29   1h 18m 47s ⏱️ - 4m 18s
 3 971 tests ±  0   3 949 ✅ ±  0   22 💤 ±0  0 ❌ ±0 
11 914 runs   - 596  11 754 ✅  - 595  160 💤  - 1  0 ❌ ±0 

Results for commit 5809f96. ± Comparison against base commit e639885.

♻️ This comment has been updated with latest results.

@stephan-herrmann
Copy link
Contributor Author

This time the tests timed out.

@merks merks merged commit 6f2754b into eclipse-platform:master Jun 21, 2024
15 of 16 checks passed
@stephan-herrmann stephan-herrmann deleted the removeCasts branch June 21, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants