Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light (Preview) theme - change in the behavior of highlights for selected tabs #2286

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Light (Preview) theme - change in the behavior of highlights for selected tabs #2286

merged 2 commits into from
Sep 18, 2024

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Sep 17, 2024 •
edited
Loading

All selected tabs in Light (Preview) theme had blue highlight(underline) irrespective of stack being active or inactive. At any point in time only one tab could be active and it has to be blue. This change has been done by making blue highlight only for the active selected tab and rest of the selected tabs which are inactive will have grey highlight.
Please find the below screen shots:

Before:
image

image

After :
image

image

@BeckerWdf
Copy link
Contributor

pls provide two PRs for the two things:

  • 1 PR for the font color stuff
  • 1 PR for the blue / grey underline-stuff

@BeckerWdf BeckerWdf modified the milestone: 4.34 M1 Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Test Results

 1 183 files   -   632   1 183 suites   - 632   40m 13s ⏱️ - 1h 3m 50s
 7 699 tests ±    0   7 469 ✅  -     2  229 💤 +  1  1 ❌ +1 
19 235 runs   - 5 023  18 901 ✅  - 4 610  333 💤  - 414  1 ❌ +1 

For more details on these failures, see this check.

Results for commit be91155. ± Comparison against base commit 8d647ea.

This pull request skips 1 test. 
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay

♻️ This comment has been updated with latest results.

@mvm-sap mvm-sap changed the title Change to font colors of sel/unsel tabs and also highlight Light (Preview) theme - change in the behavior of highlights for selected tabs Sep 17, 2024
BeckerWdf
BeckerWdf requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@BeckerWdf BeckerWdf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adaptions to the macOS and the gtk version of the theme is missing.

@BeckerWdf BeckerWdf mentioned this pull request Sep 17, 2024
Open
12 tasks
@mvm-sap
Change to the behaviour of highlight for selected tabs
f580698 
In Light (Preview) theme, all selected tabs in editor and views had blue
highlight(underline) irrespective of whether the view stack is active or
not. This behaviour has been changed via this change, by making only one
tab with blue underline which is active, rest of the selected tabs in
inactive stack will have grey underline. Changes have been done for Win,
Mac and Linux
@BeckerWdf
Copy link
Contributor

adaptions to the macOS and the gtk version of the theme is missing.

This is fixed now. Looks good on macOS.

BeckerWdf
BeckerWdf requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@BeckerWdf BeckerWdf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a version bump is needed to the org.eclipse.ui.themes plugin's MANIFEST.MF.
Pls. add is as a separate commit (title e.g. "Version bumps for 4.34 stream")

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Sep 17, 2024

pls provide two PRs for the two things:

  • 1 PR for the font color stuff
  • 1 PR for the blue / grey underline-stuff

This PR has changes related to tab higlight

@BeckerWdf BeckerWdf mentioned this pull request Sep 18, 2024
Closed
@mvm-sap
Copy link
Contributor Author

mvm-sap commented Sep 18, 2024

I think a version bump is needed to the org.eclipse.ui.themes plugin's MANIFEST.MF. Pls. add is as a separate commit (title e.g. "Version bumps for 4.34 stream")

Done

@BeckerWdf
Copy link
Contributor

failing verification jobs seem unrelated.

@BeckerWdf BeckerWdf merged commit 6fb8fb3 into eclipse-platform:master Sep 18, 2024
12 of 16 checks passed
@mvm-sap mvm-sap deleted the Tab_text_color_changes branch September 23, 2024 05:00
@BeckerWdf BeckerWdf mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeckerWdf BeckerWdf BeckerWdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.34 M1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvm-sap @BeckerWdf