Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'Git Staging' view background #2168

Merged

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Aug 7, 2024

There was inconsistency in the background colors for sections and toolItems in the Git Staging view after introducing the enhancements to the light theme #2114 (comment). It has been fixed with this change in Win, Mac and Linux. Section and ToolItem now has same grey as background color.

image

image

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Test Results

 1 815 files  +  191   1 815 suites  +191   1h 43m 6s ⏱️ + 24m 32s
 7 687 tests ±    0   7 459 ✅ ±    0  228 💤 ±  0  0 ❌ ±0 
24 222 runs  +1 191  23 473 ✅ +1 072  749 💤 +119  0 ❌ ±0 

Results for commit 176dc4c. ± Comparison against base commit 2e593cd.

♻️ This comment has been updated with latest results.

@BeckerWdf
Copy link
Contributor

Pls. don't add merge commits to the PR. Please rebase instead.

@mvm-sap mvm-sap force-pushed the Fix_Git_Staging_View_Background branch from 97f0834 to 176dc4c Compare August 7, 2024 09:21
@mvm-sap
Copy link
Contributor Author

mvm-sap commented Aug 7, 2024

Pls. don't add merge commits to the PR. Please rebase instead.

okay sure.

@BeckerWdf BeckerWdf added this to the 4.33 M3 milestone Aug 7, 2024
@BeckerWdf BeckerWdf merged commit 2a0848d into eclipse-platform:master Aug 7, 2024
16 checks passed
@mvm-sap mvm-sap deleted the Fix_Git_Staging_View_Background branch August 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants