Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for background color of some views like Types, Console etc #2153

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Aug 3, 2024

Implementing fix for background color change to some of the views like Console View, Types View etc.
Background color of these views was white, with this change it has been changed to grey(#f8f8f8) to harmonize with other views.
Refer #2114 (comment) - "Types" view does not have a grey background. Fix has been provided in Mac, Win and Linux.

image

image

Copy link
Contributor

github-actions bot commented Aug 3, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 34m 26s ⏱️ - 1m 57s
 7 684 tests ±0   7 456 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 213 runs  ±0  23 464 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 71edf6b. ± Comparison against base commit e41945c.

@BeckerWdf
Copy link
Contributor

tested on macOS. Looks good.

@BeckerWdf BeckerWdf added this to the 4.33 M3 milestone Aug 5, 2024
@BeckerWdf BeckerWdf merged commit 50061d4 into eclipse-platform:master Aug 5, 2024
16 checks passed
@mvm-sap mvm-sap deleted the Views_bg_color_fix branch August 5, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants