Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix- Background color for gutter line in editor #2144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Aug 1, 2024

Implementing fix for gutter line background change in dark theme for Win and Mac.
Ref 4th issue reported in #2114 (comment)

image

image

Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?

@BeckerWdf
Copy link
Contributor

Implementing fix for gutter line background change in dark theme for Win and Mac. Ref 4th issue reported in #2114 (comment)

image

image

I don't see a difference. Do I overlook something? You pls. highlight the areas that have changed in the before and after image?

Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?

What did you add in the CSS spy and how does it look before and after that change in CSS spy?

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test Results

 1 210 files   -   605   1 210 suites   - 605   52m 31s ⏱️ - 44m 28s
 7 684 tests ±    0   7 456 ✅ +    2  228 💤 ±  0  0 ❌  - 2 
16 142 runs   - 8 071  15 673 ✅  - 7 789  469 💤  - 280  0 ❌  - 2 

Results for commit 2fb2f80. ± Comparison against base commit a547aa4.

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Aug 1, 2024

image

image

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Aug 1, 2024

I don't see a difference. Do I overlook something? You pls. highlight the areas that have changed in the before and after image?

Was able to fix only this part (strip next to vertical scroll bar) of the editor. Unable to change the gutter line background. It works when I change via CSS spy but not via css file. Any suggestions on this ?

What did you add in the CSS spy and how does it look before and after that change in CSS spy?

Updated screen shots for both

@BeckerWdf
Copy link
Contributor

ok now I get it.

Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Aug 1, 2024

Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.

Changed the background color of composite (CSS ID - org-eclipse-e4-ui-compatibility-editor) from #2f2f2f to #1E1F22 (background color of text editor)

@BeckerWdf
Copy link
Contributor

Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.

Changed the background color of composite (CSS ID - org-eclipse-e4-ui-compatibility-editor) from #2f2f2f to #1E1F22 (background color of text editor)

@vogella: Can you help @mvm-sap with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants